Feedback Week1 and Week2
Principles and Practice Feedback
Comments
Final project website
Very nice and entertain description.
- As Neil always says: Use the Final project page as a diary. Try to write something there each week, explaining how each week's assignment has contributed to your final project.
From Assessment guide
-
Sketched your final project idea/s -
Described what it will do and who will use it
Project Management
Comments
About me website
Good!
Description of the website
I strongly recommend you to include the name of each week. When you are in week 15, you won't remember which week was the computer control machining (for instance)!!!Which is the template that you finally used? How you modified the files?- Would it be nice to provide the file structure of your repo as well as a small description of the layout (where you have the menus, e.g. )
Description of the GIT process
You say:
Last thing, which you need to do it is to make your webpage public. GIT is a programme, which you may use.
That is not totally true. GIT just works with repositories, but does not allow you to publish anything on the web. It is an "extra" service provided by Gitlab which allows to host a website with the content of your repo.
-
Please clarify which is the command that you used to generate the ssh key. Why do you need a public/private key pair?. How did you upload the public key to git page. Clarify whatgit pull
andgit push
really do. You forgot to mention also the commandsgit add
andgit commit
You say:
~~ Nevertheless, one of the files is not up to date.~~
The .gitlab.ci.yml is the Gitlab Continous Integration configuration file. In your case, what it does is taking the content of your remote master branch and deploys it in a Web Server (nginx in this case, but this is not important in this case). This is what makes your website publicly visible. Please correct.
Other comments
- Some typos:
- differnt -> different
- Troubleshooing -> Troubleshooting
From Assessment guide
-
Made a website and described how you did it -
Introduced yourself -
Documented steps for uploading files to archive -
Pushed to the class archive -
Signed and uploaded Student Agreement
Edited by Ivan Sanchez Milara